threadheap / serverless-ide-vscode

Serverless IDE: Enhanced support for AWS SAM and CloudFormation in VS Code
https://serverless-ide.com/
195 stars 45 forks source link

Adds python3.9 as a valid value for provider.runtime for sls framework #143

Closed username-dot-com closed 2 years ago

username-dot-com commented 3 years ago

This PR fixes an issue where the plugin was incorrectly reporting python3.9 as an invalid value for provider.runtime when using Serverless Framework.

danfsd commented 3 years ago

Hey @pavelvlasov, would you mind taking a look into this PR? Seems pretty simple and I for instance would benefit from this addition!

Thanks in advance

zegheim commented 3 years ago

@pavelvlasov please approve this benign review if possible. This helps tor reduce the number of false positives I get when linting

jayfry1077 commented 2 years ago

@pavelvlasov Any chance you can approve this?

relsunkaev commented 2 years ago

Anyone else who could be tagged beside @pavelvlasov? He maintains a lot of pretty important packages so he might be busy for a while and those squiggly lines sure are annoying.