threadheap / serverless-ide-vscode

Serverless IDE: Enhanced support for AWS SAM and CloudFormation in VS Code
https://serverless-ide.com/
195 stars 45 forks source link

Add support for VPC nullification #145

Closed HowManyOliversAreThere closed 2 years ago

HowManyOliversAreThere commented 3 years ago

VPCs may be explicitly disabled via YAML null values (empty line, ~, or null) or false as of https://github.com/serverless/serverless/pull/10060. This change allows these new values to be set without any errors appearing.

~ and null, which should be null values as per yaml spec (https://yaml.org/spec/1.2.2/) seem to be recognised as string types with an empty string as value, so there's more options than expected for the allowed values.

Only the function-level VPC logic was changed in serverless but this ability to specify no VPC should be valid for both the function-level and provider-level VPC configs. This means that the shared use of this configuration type in this repo should still be valid.