Not working in TB 115.0.1

gruniversal commented 1 year ago

Mozilla now switches to the "supernova" version of thunderbird.

The current addon version does not work with supernova.

I would be glad so have an update, so that it is working again.

ahubmann commented 1 year ago

Working on that, basic functionality is there already. Still need to completely figure out the new UI structure to correctly overlay on both 3-pane tabs, message tabs as well as the statusbar.

ahubmann commented 1 year ago

Here's a first beta version, feedback highly welcome. Note: this version only works on Thunderbird 115.x.

ThreadVis-3.5.0.beta.1.zip

(.zip as GitHub doesn't support .xpi attachments. Luckily Thunderbird reads .zips as well.)

basti3333 commented 1 year ago

Not yet fully tested, but the beta seems to work fine! Thanks for the swift work, saved my life after TB auto-update! Just donated, keep up the great work!

foostuff commented 1 year ago

Just wanted to leave my "thank you" here. The core functionality seems to work flawless.

ErikKrause commented 1 year ago

The ThreadVis beta works immediately after I install it. After I close thunderbird and open it again, all settings are gone and ThreadVis doesn't show up and the devtools don't find an element named "ThreadVis" any more. If I re-install it, it works again. TB 115.3.1 (32-Bit) on Windows 10

ahubmann commented 1 year ago

The ThreadVis beta works immediately after I install it. After I close thunderbird and open it again, all settings are gone and ThreadVis doesn't show up and the devtools don't find an element named "ThreadVis" any more. If I re-install it, it works again. TB 115.3.1 (32-Bit) on Windows 10

Ok, this is weird. Trying to replicate this, I saw the same thing happening to my Thunderbird (open for quite a while now, ThreadVis already installed) once (macOS):

Install ThreadVis
Close Thunderbird
Re-open, ThreadVis is gone
Re-install ThreadVis
Close Thunderbird
Re-open: ThreadVis is there, as expected.

I've re-done this cycle now 10 times (uninstall, restart, reinstall, restart), but so far it's always been working as expected.

Does it stay installed after you've repeated the install process?

ErikKrause commented 1 year ago

No, it is always gone if I close and restart thunderbird. Do you have a suspicion? Where can I look? Could it be this is because I didn't uninstall the previous version? There are only five lines with threadvis in the prefs.js. Shouldn't there be more?

squintarelli commented 1 year ago

I am using thunderbird 115.3. on ubuntu installed from the zip file, does'nt appear in thunderbird's UI.

RobertBorst commented 1 year ago

Installed on 115.3.1 on windows 10, works as expected, Stopped TB and started again, It remains visible, not other extensions installed.

ErikKrause commented 1 year ago

No, it is always gone if I close and restart thunderbird.

Somehow threadvis doesn't read it's settings. But if I disable it and then enable it again, the settings are there and it works again.

marcalia commented 1 year ago

Quick test on TB 115.3.1 (64bit) on Ubuntu 22.04.1. After install: works as expected After closing TB and reopening it after a few seconds: works as expected After restart of the system: no thread-indicator visible, Add-on still in Add-ons-menu, after deactivation and re-activation works as expected

ahubmann commented 1 year ago

After closing TB and reopening it after a few seconds: works as expected After restart of the system: no thread-indicator visible, Add-on still in Add-ons-menu, after deactivation and re-activation works as expected

Hm. This is weird. Restarting TB and restarting the system and starting TB should not make a difference. Is the statusbar icon visible in TB (lower right) after a system restart?

ahubmann commented 1 year ago

No, it is always gone if I close and restart thunderbird.

Somehow threadvis doesn't read it's settings. But if I disable it and then enable it again, the settings are there and it works again.

Maybe you're on to something there. ThreadVis is still using the "old" preferences settings (which you can edit via "Config Editor..." in the main "Settings -> General" tab). I'll test on a clean setup in a virtual machine, can't reproduce this on my laptop.

ahubmann commented 1 year ago

I am using thunderbird 115.3. on ubuntu installed from the zip file, does'nt appear in thunderbird's UI.

Does it show up as an installed add-on? If so, could you check "Tools" -> "Developer Tools" -> "Error Console" for any (red) errors after startup?

marcalia commented 1 year ago

Funny thing. I repeated the process.

shutdown and re-start system and start TB -> status bar visible, thread-indicator not; Add-on "active" in add-on manager
deactivating and re-activating Add-on -> thread-indicator visible, works fine
shutting TB down and re-starting it -> thread-indicator visible, works fine; error console shows some errors I cannot really assign to this Add-on.

And then...

shutdown and re-start system and start TB -> thread-indicator visible, works fine

I will test it again. Couldn't imagine opening the error console one would fix this behavior. I cannot post the screenshots I made because I am running firefox in firejail and it doesn't allow drag-n-drop from thunar.

marcalia commented 1 year ago

Did not cure it. After a re-start of the system the situation is as described previously. ThreadVis is showing in the status bar, no thread-indicator, switching ThreadVis off and on again brings it back. I would upload the screenshots but I dont know how to get it in the firejail sandbox with firefox.

marcalia commented 1 year ago

OK, clicking on the bar below with the "Attach files by dragging & .. " also works! Just act "stupid" and try things works best! :-)

After reboot: Bildschirmfoto_2023-10-10_12-16-13

Bildschirmfoto_2023-10-10_12-16-53

After switching off and on:

Bildschirmfoto_2023-10-10_12-17-17

After shutting TB down and starting it again: Bildschirmfoto_2023-10-10_12-17-58

Error console: Bildschirmfoto_2023-10-10_12-19-46

After reboot as described earlier: Bildschirmfoto_2023-10-10_12-21-45

After reboot again: Bildschirmfoto_2023-10-10_12-40-31

Bildschirmfoto_2023-10-10_12-40-58

foostuff commented 1 year ago

FYI: TB 115.3.1 64bit on Win10 with Threadvis 3.5.0.beta.1 from this thread survived multiple Windows reboots and of course TB restarts. Everything fine here. (I have another issue with "everything is blank" sometimes when I start thunderbird. But then I start TB again and everything is back to normal. But that seems to be a completely different problem :) )

ahubmann commented 1 year ago

Final version of 3.5.0 now available here: https://github.com/threadvis/ThreadVis/releases/tag/3.5.0

If you're still seeing install issues with the above, please let me know

ErikKrause commented 1 year ago

Somehow threadvis doesn't read it's settings. But if I disable it and then enable it again, the settings are there and it works again.

This is still the same with 3.5.0

Der-Dings commented 1 year ago

My TB has updated itself (without being asked) to Supernova (version 115.3.2). So I installed version 3.5.0 of ThreadVis and one day (and one computer restart) later I can report problem-free operation so far.

cheekybuddha commented 1 year ago

Was using the beta version with some success, the timeline view was often cut off horizontally, ie only 'top half' visible.

Just auto update to 3.5.0. Now the timeline flashes visible for a second and then disappears completely.

TheadVis 3.5.0 TB 115.3.3 (64-bit) OS Ubuntu 20.04

Anyone else seeing this, or have a solution to suggest?

TIA

Edited to add It seems to happen when a message has a Tag, and the Tags line is displayed below To: Without Tags, I still see the timeline cut in half horizontally (sometimes!)

ahubmann commented 1 year ago

Edited to add It seems to happen when a message has a Tag, and the Tags line is displayed below To: Without Tags, I still see the timeline cut in half horizontally (sometimes!)

In my Thunderbird, tags are displayed as the last header row and I'm seeing no issues:

But then again, I'm mangling the header display quite a bit to get the visualisation in, so I'm sure things can break in some instances. Can you post a screenshot of the headers when it's not working as expected?

cheekybuddha commented 1 year ago

OK, the problem is that nothing is consistent!!

Normal email, no tag, bottom of timeline cut off. Also placement shifted left.
Everything OK.
Placement normal, but bottom of timeline cut off.
Email with tag. On first selection timeline displayed OK.
Switch to different email and then back to previous, timeline flashes and immediately disappears.

I'm having problems uploading images so here is a link to the images in my pCloud: https://e.pcloud.link/publink/show?code=kZNjHsZXo8NWwgEBQuDGdQIHhOTjy6oaNPk

ahubmann commented 1 year ago

Thanks for the screenshots. As there's a caret-down symbol next to the "From" header: do you have any other add-ons installed that alter the message headers?

cheekybuddha commented 1 year ago

Yes, I have:

Compact Headers 5.1 Message Header Toolbar Customize 2.4.1 Toggle Headers 3.0

I will try disabling/re-enabling them to see which is conflicting.

cheekybuddha commented 1 year ago

OK, re-enabling one-by-one (and restarting):

Compact Headers - causes issues Message Header Toolbar Customize - no issues Toggle Headers - ThreadVis timeline disappears on showing of full headers, does not re-appear on collapse. Switch to different email and switch back then timeline re-appears.

Hope that helps.

ahubmann commented 1 year ago

Attached ThreadVis-3.5.1.beta.1.zip, which should be compatible with Compact Headers.

As both add-ons modify the same header area, the necessary styling for ThreadVis was removed by Compact Headers. I've now added a MutationObserver to catch modifications and re-apply mine. Seems this also helps when displaying full headers.

Feedback highly welcome.

cheekybuddha commented 1 year ago

Looking very good!

There is a small (almost negligible!) issue after expanding and then collapsing the full headers view, but I will post screenshots to explain later today when I get a moment.

Many thanks!