threatgrid / ctim

Cisco Threat Intellligence Model
Eclipse Public License 1.0
68 stars 34 forks source link

adds incident_time.created #416

Closed agzam closed 1 year ago

agzam commented 1 year ago

We need to expose created field even though it won't be stored explicitly in CTIA.

Related: https://github.com/advthreat/iroh/issues/7866

The discussion: https://github.com/advthreat/iroh/issues/7853#issuecomment-1540591124

agzam commented 1 year ago

we did not concluded that. Wait for the team.

Of course. Even if approved, I have to run a bunch of tests, etc., I won't merge it before that. And by the way, for some reason it's allowing me to merge even without any reviews and with a change request. Can you check the repo settings?

image

ereteog commented 1 year ago

see https://github.com/advthreat/iroh/issues/7917