search

threatstack / threatstack-ansible

Ansible for installing Threatstack Agent
https://www.threatstack.com
MIT License
23 stars 17 forks source link

Amazon2 tweaks #48

Closed Shplorf closed 5 years ago

Shplorf commented 5 years ago
olhado commented 5 years ago

----- Original message ----- From: Pedro Medeiros notifications@github.com To: threatstack/threatstack-ansible threatstack-ansible@noreply.github.com Cc: Michael Chmielewski github@mikec.123mail.org, Comment comment@noreply.github.com Subject: Re: [threatstack/threatstack-ansible] Amazon2 tweaks (#48) Date: Friday, February 08, 2019 2:03 PM

@pedroMMM commented on this pull request.

In tasks/disable_auditd.yml https://github.com/threatstack/threatstack-ansible/pull/48#discussion_r255199810:

@@ -0,0 +1,14 @@ +--- +- name: check auditd status

  • command: service auditd status
  • register: auditd_status
  • ignore_errors: true
  • changed_when: false

  • +- name: Stop service auditd

  • command: service auditd stop
  • when: auditd_status.rc == 0

  • +- name: Disable service auditd

  • command: systemctl disable auditd
  • when: auditd_status.rc == 0

Shouldn't it be when: auditd_status.rc != 0?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/threatstack/threatstack-ansible/pull/48#pullrequestreview-201738901, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA6v8yiSLpA3slCvAcgDbYbmJjA-sFZks5vLcoSgaJpZM4awYwA.

-- Mike Chmielewski mikec@123mail.org