three-rs / three

[abandoned] Totally not inspired Rust 3D library
Apache License 2.0
555 stars 46 forks source link

Preserve existing scale in Object::look_at #209

Closed LPGhatguy closed 6 years ago

LPGhatguy commented 6 years ago

Object::look_at resets the scale of the object to 1. This PR makes it not do that.

This can be demonstrated with a small snippet: https://gist.github.com/LPGhatguy/dc9b4323b3ce7ca950ae936b95038acd

With the correct behavior, the sphere should fill the screen vertically. In 0.3.1 as well as the current master, however, the sphere's scale is reset to 1.0 and no longer fills the screen after look_at.

bors[bot] commented 6 years ago

Build succeeded