search

threeML / astromodels

Spatial and spectral models for astrophysics
BSD 3-Clause "New" or "Revised" License
44 stars 45 forks source link

Negative Flux in astromodels #163

Closed omodei closed 2 years ago

omodei commented 3 years ago

Some users asked the possibility to have negative flux when doing their analysis, but the log transformation avoids the possibility to do this. Would be nice to have a way to disable log scaling.

grburgess commented 3 years ago

@omodei Ok, I've added the context managers and the ability to do this in the configuration.

to get an idea you can have a look at the test:

https://github.com/threeML/astromodels/blob/feature-native-node/astromodels/tests/test_parameter.py#L144

A word of caution, if someone fits with transforms and then tries to do a profile with them off... it will lead to incorrect results because the MLE point of a transformed parameters != MLE point of the non-transformed parameter except in a very few special cases of transforms.. and not log10.

github-actions[bot] commented 3 years ago

This issue has become stale. Is there an update? We will close in 15 days

omodei commented 2 years ago

Why this issue was reopened? I though you fix it.

omodei commented 2 years ago

Can we close this issue or there is still development to do?