threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis

BSD 3-Clause "New" or "Revised" License

12 stars 22 forks source link

Psf fixes #10

Closed henrikef closed 6 years ago

henrikef commented 6 years ago

Only set up PSF convolutors for active bins to avoid HAL crashing due to invalid PSFs.

henrikef commented 6 years ago

Travis CI test timed out on linux (test_goodness was the culprit) but passed (in a fraction of the time) on macos :/

I'll fix the formatting issues, sorry about that.

codecov[bot] commented 6 years ago

Codecov Report

Merging #10 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   93.52%   93.52%   +<.01%     
==========================================
  Files          38       38              
  Lines        1451     1452       +1     
==========================================
+ Hits         1357     1358       +1     
  Misses         94       94

henrikef commented 6 years ago

Not sure if my previous comment went through because I don't see it anymore, but I added a call to set_model after changing the analysis bins. That should fix the issue that arises if the user wants to change analysis bins later on.

Right now, the build tests are failing for the linux system due to an unrelated issue (it can't find the module threeML.utils.polarization.binned_polarization.)