search

threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis
BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Save InvalidPSF to HDF5 format #16

Closed colasri closed 5 years ago

colasri commented 5 years ago

We can't convert detector response files of the energy estimators to HDF5 because they contain InvalidPSF instances. One way to solve it would be to allow writing of the InvalidPSF class. Any opinion @giacomov ?

giacomov commented 5 years ago

Would you prefer writing InvalidPSF instances (an easy fix), or not writing in the file invalid bins?

I believe you already implemented the possibility of loading responses with missing bins, right?

colasri commented 5 years ago

I think there is a check somewhere that each declination has the same number of analysis bins (planes), so writing InvalidPSF would probably induce the minimum number of changes.