added support for opening old hawc style maptrees

threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis

BSD 3-Clause "New" or "Revised" License

11 stars 22 forks source link

added support for opening old hawc style maptrees #23

Closed cbrisboi closed 5 years ago

cbrisboi commented 5 years ago

This pull request is to fix #21.

cbrisboi commented 5 years ago

@henrikef I was asking about these commits. I'll search for the other place in the code where this was addressed.

cbrisboi commented 5 years ago

in response.py, starting on line 195. I'll match the two to follow the same error messages

henrikef commented 5 years ago

Looks good to me. Apparently I worked on this previously, but only fixed it for the response file, not the maps. See

https://github.com/threeML/hawc_hal/pull/2

https://github.com/threeML/hawc_hal/blob/3ec5e1fd8c635133cda2f5a93049967264a9c809/hawc_hal/response/response.py#L194

henrikef commented 5 years ago

Regarding the tests: Can you set the geminga paper test to xfail for now? It fails because parameters aren't automatically unlinked when a source is removed. Addresded in https://github.com/threeML/astromodels/pull/101 , but I need a bit of time to work on that pull request.