search

threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis
BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Cannot manually specify ntransits #32

Closed cbrisboi closed 3 years ago

cbrisboi commented 4 years ago

In liff, you could specify the transits to use for the maps during analysis. I just noticed while working on an unrelated task that we cannot do the same for hal.

This should be straightforward to implement, a good task for a graduate student wanting to learn. Otherwise, I'll get to it eventually

github-actions[bot] commented 3 years ago

This issue has become stale. Is there an update? We will close in 14 days

maloneka commented 3 years ago

@cbrisboi is anyone actively working on this? This would be nice to have as we work on validation of pass 5 with the Crab strip.

henrikef commented 3 years ago

@maloneka There is a branch that implements this functionality (see #43 ). Feel free to test that branch on the Crab strip etc! It still needs unit tests for the new functionality before it can be merged to the master, though.

github-actions[bot] commented 3 years ago

This issue has become stale. Is there an update? We will close in 14 days

maloneka commented 3 years ago

@cbrisboi status update? Does this pass the tests yet?

github-actions[bot] commented 3 years ago

This issue has become stale. Is there an update? We will close in 14 days