search

threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis
BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Pass file names as string instead of posix path objects so root knows… #48

Closed henrikef closed 3 years ago

henrikef commented 3 years ago

… what to do with them

henrikef commented 3 years ago

Ok, so this fixes the errors described here: #45 (Explanation: The updated threeML.io.file_utils.sanitize_filename returns a filepath.PosixPath object which we have to explicitly convert to a string for root to be able to handle.

The test against the master branch of threeML still fails due to the changes to the progress bar, which should be fixed (🤞) with #46.

What I don't understand is why the Geminga test fails now: Looks like it converges, but the fit parameters are off from the expectations.

I would suggest going ahead and merging this, and making a new issue for the Geminga test.

henrikef commented 3 years ago

The tests pass (except for Geminga) using the conda version of threeML/astromodels, so I'm going to merge this so we can move on.