threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis

BSD 3-Clause "New" or "Revised" License

11 stars 22 forks source link

Add color bar option to display_fit() #5

Closed colasri closed 6 years ago

colasri commented 6 years ago

Wait, there's a crash with the 2D binning: File "/Users/cr/miniconda2/envs/myconda/lib/python2.7/site-packages/matplotlib/colorbar.py", line 920, in __init__ mappable.autoscale_None() AttributeError: 'list' object has no attribute 'autoscale_None' Plus travis is not happy, not sure why...

giacomov commented 6 years ago

Ignore Travis, it's behaving today. Other tests are failing as well.

But please fix the problem with the 2d.

Thanks!

codecov[bot] commented 6 years ago

Codecov Report

Merging #5 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   92.32%   92.35%   +0.02%     
==========================================
  Files          38       38              
  Lines        1447     1451       +4     
==========================================
+ Hits         1336     1340       +4     
  Misses        111      111

colasri commented 6 years ago

Nevermind, there was no issue with the committed code, just a typo in my local version when trying to satisfy Scrutinizer. The current version should be good to go.