search

threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis
BSD 3-Clause "New" or "Revised" License
11 stars 21 forks source link

Adding the `scripts` directory as executables during install #57

Closed hayalaso closed 2 years ago

hayalaso commented 3 years ago

Feature Request

Adding the variable scripts=[], in the setup function of setup,py can put the scripts, such as hal_hdf5_to_fits.py in the path for easy use.

grburgess commented 3 years ago

I recently figured out how to do this and can help with the click package.

github-actions[bot] commented 3 years ago

This issue has become stale. Is there an update? We will close in 14 days

hayalaso commented 3 years ago

@cbrisboi I can add this, but I just want to make sure about which scripts we want to be executables. Besides hal_hdf5_to_fits.py, is there another one we want?

cbrisboi commented 3 years ago

We can add the point source script too. I dont see a reason not to, although its of somewhat limited use. Having the two scripts from the readme in there would be extremely helpful though.

Quick thing I noticed about the hal_hdf5_to_fits.py. The start and end MJD's are hardcoded from when I wrote it originally. We should convert those to arguments and perhaps choose updated values for the default.

hayalaso commented 3 years ago

Ok, we can do it in steps. I'll make a branch to add the scripts as install programs and then work on improving the scripts in another branch.

github-actions[bot] commented 3 years ago

This issue has become stale. Is there an update? We will close in 14 days