threeML / hawc_hal

HAWC Accelerated Likelihood - python-only framework for HAWC data analysis

BSD 3-Clause "New" or "Revised" License

13 stars 22 forks source link

Add a background column when plotting the planes. #8

Closed colasri closed 6 years ago

colasri commented 6 years ago

Display the background too. Do not smooth the background with a Gaussian kernel, since we do want to know if the background (as used in the computation) is smooth enough or if there are issues.

colasri commented 6 years ago

display_fit exemple

giacomov commented 6 years ago

Very nice!

Since you are at it, you might want to set the color scale (vmin and vmax keywords) to the same value for both model and excess, so they are easier to compare.

If not, I'll do it in a future commit.

codecov[bot] commented 6 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   93.41%   93.42%   +0.01%     
==========================================
  Files          38       38              
  Lines        1442     1445       +3     
==========================================
+ Hits         1347     1350       +3     
  Misses         95       95

colasri commented 6 years ago

I think this PR is ready to merge.

giacomov commented 6 years ago

ok, merging.

I see that the Travis Linux build is still failing here, probably you are behind a few commits from master.

It is fine for this fork, I'll merge anyway, but if you have other forks around make sure to go back in sync with master.

Thanks!