search

threedayAAAAA / vite-plugin-circular-dependency

Detect circular dependencies
MIT License
34 stars 2 forks source link

Infer entry point from "load" #8

Closed RedHatter closed 8 months ago

RedHatter commented 8 months ago

The current version tries to infer the entry point or "root module" by the first module passed through moduleParsed however that's not actually necessarily the root. In my case I had ~10 different modules passed through that function before my entry point file.

This PR instead infers the entry point by the first module id passed through the load function. This can actually be guaranteed to be the root.

threedayAAAAA commented 8 months ago

Thank you very much for your support of this project. There seems to be a small problem in this PR. I have pointed it out above. We can discuss it together.

RedHatter commented 8 months ago

Thanks for the reply!

I have pointed it out above.

I don't see any other comments.

threedayAAAAA commented 8 months ago

Thanks for the reply!

I have pointed it out above.

I don't see any other comments.

Sorry, I seem to have forgotten to end the review, hhh

RedHatter commented 8 months ago

How's this?