search

threedi / hhnk-threedi-tools

1 stars 0 forks source link

github action naar master research tools laten kijken #43

Open wvangerwen opened 1 year ago

wvangerwen commented 1 year ago

Zodat we tests kunnen draaien zonder dat we de wijzigingen op researchtools moeten publishen op pypi.

ERROR: Invalid requirement: 'git https://github.com/hhnk-research-tools.git@master' (from line 12 of D:\a\hhnk-threedi-tools\hhnk-threedi-tools\envs\condaenv.1bxpn0lu.requirements.txt)
Installing pip dependencies: ...working... Ran pip subprocess with arguments:
d2hydro commented 1 year ago

Zodat we tests kunnen draaien zonder dat we de wijzigingen op researchtools moeten publishen op pypi.

ERROR: Invalid requirement: 'git https://github.com/hhnk-research-tools.git@master' (from line 12 of D:\a\hhnk-threedi-tools\hhnk-threedi-tools\envs\condaenv.1bxpn0lu.requirements.txt)
Installing pip dependencies: ...working... Ran pip subprocess with arguments:

Link should be git+https://github.com/HHNK/hhnk-research-tools.git@master

If I test this locally I get:

ERROR conda.core.link:_execute(740): An error occurred while installing package 'conda-forge::bzip2-1.0.8-h8ffe710_4'.
Rolling back transaction: done

[Errno 13] Permission denied: 'C:\\ProgramData\\miniconda3\\envs\\hhnk_threedi\\Library\\bin\\libbz2.dll'
()

What works:

  1. exclude hrt from environment_test.yml and create environment
  2. install hrt with pip install git+https://github.com/HHNK/hhnk-research-tools.git@master after

I've modified tests-conda.yml including:

      - name: Install hhnk-research_tools
        shell: pwsh
        run: pip install git+https://github.com/HHNK/hhnk-research-tools.git@master

Let's see how that goes

d2hydro commented 1 year ago

fixed met #42

wvangerwen commented 1 year ago

ThreediRasters.initial_wlvl_2d toegevoegd in hrt. Action werkt na een uur nog niet.

https://github.com/threedi/hhnk-threedi-tools/actions/runs/5587900553/jobs/10213879818?pr=51