search

threefoldfoundation / tfchain

Official implementation of the ThreeFold blockchain
https://explorer.threefoldtoken.com
Apache License 2.0
13 stars 7 forks source link

support refund coin outputs and semi-support 3bot fee payouts #201

Closed GlenDC closed 5 years ago

GlenDC commented 6 years ago

Can you help finish of this PR @LeeSmet, there is one more thing that has to be done (see the added TODO). Not sure how we best tackle this, but as it is, I do not see an easy way to compute the coin output value from the 3Bot fee payouts).

LeeSmet commented 6 years ago

If the only objective is to calculate the exact amount of TFT used as botfee, I think the best approach would be to calculate said fee in the appendVXXXTransaction methods, and then pass it down to the right functions. Also there is currently not a table for the BotFee related txns.

Perhaps it is best to first calculate the BotFee output, and then add it as the first element when the usual coinoutputs array is replaced (this would mean there are 2 elements in that array, and then the issue I mentioned can be fixed by just passing index 1 when invoking the functions to append the refund condition). Then the table showing the BotFee can just be filled in as a regular output table referencing output 0 I think

GlenDC commented 5 years ago

Deprecated and replaced by commit 4b6680cc1a6e45a3254a1315072c036956a09a2a, while doing some other work on the web explorer.