search

threefoldfoundation / tft-stellar

Threefoldtoken on the stellar network
Apache License 2.0
7 stars 5 forks source link

hosting the faucet on https://freetftfaucet.testnet.threefold.io does not work #87

Closed robvanmieghem closed 4 years ago

robvanmieghem commented 4 years ago

Looks like the served html contains absolute paths, for example:<link rel=icon href=/threefoldfoundation/stellar_faucet/3logo.png>

DylanVerstraete commented 4 years ago

I think the base path should be modified here to just /:

and also modify to /#/callback: https://github.com/threefoldfoundation/tft-stellar/blob/2a8e6d3f654dddf89a8929eb93f407c0b4e2a80e/ThreeBotPackages/stellar_faucet/faucet_frontend/public/config.js#L4

All these files in faucet_frontend folder should be modified and after you should make another build: npm run build

If you change the /threefoldfoundation/stellar_faucet path to / you can fetch the files: https://freetftfaucet.testnet.threefold.io/js/app.ae9821f2.js

robvanmieghem commented 4 years ago

I don't really get it to be honest, why should all these paths start with a / ?

DylanVerstraete commented 4 years ago

Because you are now serving this faucet on / instead of threefoldfoundation/stellar_faucet

robvanmieghem commented 4 years ago

Exactly, the absolute paths now have to be modified which would not have been the case if it were relative paths.

DylanVerstraete commented 4 years ago

@robvanmieghem we can keep this in mind for later, but can you change the values and try to redeploy?

DylanVerstraete commented 4 years ago

added docs in: https://github.com/threefoldfoundation/tft-stellar/commit/64a99ffeadad81898ce679497122f6bf41088bf1