search

threefoldfoundation / tft

Threefold token
Apache License 2.0
5 stars 1 forks source link

Stellar account activation from Ethereum #241

Closed robvanmieghem closed 1 year ago

robvanmieghem commented 1 year ago

Solves #240

robvanmieghem commented 1 year ago

Logic looks sounds but I have some remarks anyway. Also, all the stellar related stuff we keep rewriting.. We should invest some time in making a package for this because it's duplicated across multiple repos.

True

Also from a architectural view the program would be better off having a connection to an indexer of the blockchain rather than to a public/private node. If it can query the indexer, it could get results faster and would not need to rely on the connection to a node, the program also does not use the blockchain node to post calls.

Also true ( besides the statement that using an indexer is faster, which I don't know) but using an indexer also has it's downsides and risks.