search

threefoldtech / 0-fs

A new filesystem for zero-os that leverage on unionfs and a thin fuse layer to get the files on demand
Apache License 2.0
0 stars 1 forks source link

Check block hash before writing #19

Closed muhamadazmy closed 5 years ago

muhamadazmy commented 5 years ago

Also make sure to sync before using the file to avoid corruption on crash

maxux commented 5 years ago

What's the performance impact ?

codecov-io commented 5 years ago

Codecov Report

Merging #19 into development will decrease coverage by 0.23%. The diff coverage is 30.76%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #19      +/-   ##
===============================================
- Coverage        34.48%   34.24%   -0.24%     
===============================================
  Files               10       10              
  Lines              464      476      +12     
===============================================
+ Hits               160      163       +3     
- Misses             279      284       +5     
- Partials            25       29       +4
Impacted Files Coverage Δ
rofs/cache.go 0% <0%> (ø) :arrow_up:
rofs/downloader.go 75.34% <33.33%> (-8.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0321ab...db71955. Read the comment docs.

muhamadazmy commented 5 years ago

What's the performance impact ?

It's really hard to tell. The performance is impacted by lots of other factors like internet connection speed. I can't do any repetitive measurements.

muhamadazmy commented 5 years ago

I will benchmark blak2b separately without the rest

muhamadazmy commented 5 years ago

I think the overhead is pretty low

image