threefoldtech / 0-stor_v2

Apache License 2.0
3 stars 1 forks source link

improvement to zstor behaviors when some meta backends down #127

Open iwanbk opened 1 week ago

iwanbk commented 1 week ago

Based on #123 discussion, i want to do full check & improvements (if needed) regarding the behavior when some of the meta backends down

iwanbk commented 1 week ago

Hi @LeeSmet What is the plan for ReplaceBackends at https://github.com/threefoldtech/0-stor_v2/blob/b81264c1ed8a1d0a056f95a4189980a8b6f3a2ed/zstor/src/actors/backends.rs#L82

I can see the Handler, but it is not called at all

LeeSmet commented 1 week ago

That's a leftover from old functionality. A long time ago there was functionality to automatically replace backends if they were full/failed. Since the feature was not used and caused a lot of complexity for maintenance, it was removed. The handler is an artifact that wasn't removed properly. If you want it can be removed.

iwanbk commented 4 days ago

The handler is an artifact that wasn't removed properly. If you want it can be removed.

OK, i'll keep it for now as reference.

iwanbk commented 3 days ago

zstor retrieve must work if there are >= 2 available meta backends

tested on both master and #129

iwanbk commented 3 days ago

check ReplaceMetaStore behavior

also fixed on #129 By adding writeable flag in the message

iwanbk commented 3 days ago

reload zstor config using SIGUSR1 must update the meta backends properly

also fixed on #129.

By re-creating the metastore when there is change in the meta zdb backends