threefoldtech / grid_deployment

Deploy a full Grid backend with docker-compose and snapshots
Apache License 2.0
2 stars 0 forks source link

Grid Stack docker compose update for dashboard suite flist #59

Closed Mik-TF closed 3 months ago

Mik-TF commented 4 months ago

Work Done

Status

Detail

Related Work

References

coesensbert commented 3 months ago

Thanks a lot for the effort. I went over the commits which look fine only that once merged would break the current flow. We have currently no grid backend stacks running on the grid or in a vm, all are bare metal machines setup exactly the same. We want to keep it this way since only changing a path for example, involves a lot of work making changes on all the live deployments. What is in this repo is also live in production.

Since also changes like using zinit are in commits, I would suggest to make a separate branch (or some other git magic) to keep the code for our bare metal deployments separate from flist compatible code. Although I'm not sure how to do that.

Since this pull request we also made changes to extracting commands, so we would need to go over integrating pv again

Mik-TF commented 3 months ago

Thanks for the feedback Bert.

So finally we won't use the flist images + dashboard apps, thus this PR is not necessary. We will do everything with docker compose, as we have already started to work on.

I will update the grid deployment project specs with this so it's clear. So I will close this PR and others that are not relevant anymore.