Update command to install nacl in install-hub.sh

threefoldtech / grid_deployment

Deploy a full Grid backend with docker-compose and snapshots

Apache License 2.0

2 stars 0 forks source link

Update command to install nacl in install-hub.sh #95

Closed A-Harby closed 1 month ago

A-Harby commented 1 month ago

Update command to install nacl in install-hub.sh

Mik-TF commented 1 month ago

@coesensbert It is OK to remove the pip steps as the steps above added the packages at the user level.

coesensbert commented 1 month ago

@coesensbert It is OK to remove the pip steps as the steps above added the packages at the user level.

ok, I should clarify better. What I mean was that while building this thing, I remember doing the opposite. So not installingvia apt, but via pip3 install ... to fix issues with nacl. So I fear it might be ubuntu version dependent since I tested on 24.04

Mik-TF commented 1 month ago

OK I see. Do you think we should have more test then? Try apt vs pip3?

@coesensbert The issue was really with this: --break-system-packages, not pip itself.

So we could do

apt update && apt install python3 python3-requests python3-pip -y
pip3 install pynacl
pip3 install redis

LMK if we should test this. Sorry if I merged too quickly!

Mik-TF commented 1 month ago

Testing on docker ubuntu 24:

coesensbert commented 1 month ago

Don't know what is best, if it's ok for Harby it's ok for me with the merged PR