threefoldtech / js-sdk

extensions to js-ng for tfgrid
Apache License 2.0
14 stars 6 forks source link

use latest git release on new vdc/threebot deployment #3348

Closed sameh-farouk closed 2 years ago

sameh-farouk commented 2 years ago

Description

we used to set SDK_VERSION env var in threebot container to the git branch that we use to clone the repo from, in both Threebot and VDC.

this PR will make this Env var default to the latest remote tag on SDK repo, so when the user deploys new threebot, VDC, or redeploy old threebot, the jssdk code in the threebot container will be checked from the latest remote release instead of the HEAD of the development branch.

another change to note, that get_latest_remote_tag function moved from the vdc_dashboard API controller to git module in js-ng, which should make sense.

Caution: this PR depends on this PR and this PR in js-ng, so should be merged and a new version of js-ng should be released before we can merge this one.

Related Issues

3349

Checklist