threefoldtech / rmb-rs

RMB implementation in rust
Apache License 2.0
3 stars 1 forks source link

Add Dockerfile and workflow for ARM #137

Closed scottyeager closed 1 year ago

scottyeager commented 1 year ago

Adds a Dockerfile and Github workflow to build and release an rmb-peer container for the arm64 architecture. See https://github.com/threefoldtech/farmerbot/issues/11 for motivation and discussion.

Notes on the builds:

General notes:

scottyeager commented 1 year ago

Thanks @muhamadazmy. I've added the entrypoint. Looks like I'll need another review since I did that before merging :slightly_smiling_face:

robvanmieghem commented 1 year ago

Thanks Scott, although I very much understand

  • All changes are adjacent to the existing workflows, to prevent any issues or complications with the mainline builds
  • The container images are tagged with a suffix -arm, for example latest-arm or v1.0.6-arm. While different architecture can coexist under a single tag, it's only possible if all are built under a single workflow run (avoided to preserve the point above)

I personally do like multi-arch container images

scottyeager commented 1 year ago

Thanks for the input @robvanmieghem. I agree and am happy to merge these into unified workflows. It will add a bit more complexity, but I can solve any kinks on the forks and submit again.