search

threefoldtech / rmb-rs

RMB implementation in rust
Apache License 2.0
3 stars 1 forks source link

Protocol writer should timeout on message expiration #165

Closed sameh-farouk closed 8 months ago

sameh-farouk commented 9 months ago

Currently, the Protocol's Writer write method will keep trying to send the message in case socket/s is not working. This method should timeout and return an error if the message expired during these attempts.

sameh-farouk commented 8 months ago

Update: PR waiting for review

@muhamadazmy I believe that we should merge this change. Although we haven’t identified the root cause of the retainer getting stuck, this fix could prevent it from getting stuck permanently, so we won’t have to restart affected nodes.