search

threefoldtech / rmb-rs

RMB implementation in rust
Apache License 2.0
3 stars 1 forks source link

Clarify the error 102 message. #174

Closed 0oM4R closed 7 months ago

0oM4R commented 7 months ago

we have faced this error recently and the error message wasn't clear Screenshot from 2023-11-12 11-33-30

https://github.com/threefoldtech/rmb-rs/blob/3a2166459eeeb4782648c7f79ba80fe4da22d68f/src/types/mod.rs#L35

we can make the error more descriptive and mention that the ttl or massage expired

muhamadazmy commented 7 months ago

I really think this is just a problem with the implementation of the client. The error response in the envelope might have a code, but will always have an error message explaining what happened.

0oM4R commented 7 months ago

I really think this is just a problem with the implementation of the client. The error response in the envelope might have a code, but will always have an error message explaining what happened.

the error we got in the client is just code: 102

https://github.com/threefoldtech/tfgrid-sdk-ts/blob/704e339146c90253c9d582fb4ebd70bcb903e054/packages/rmb_direct_client/lib/client.ts#L332

i tried to log the envelop.error and got the same message: Screenshot from 2023-11-16 11-10-29

muhamadazmy commented 7 months ago

That is so weird, I will take another look.

muhamadazmy commented 7 months ago

@0oM4R Can you explain to me where the Error object in the screenshot above is coming from ? because that's not what rmb sends back. this has been constructed somewhere else in the code from the original response