peers on different relays can't call each other

threefoldtech / rmb-rs

RMB implementation in rust

Apache License 2.0

3 stars 1 forks source link

peers on different relays can't call each other #192

Closed Omarabdul3ziz closed 3 months ago

Omarabdul3ziz commented 3 months ago

the issue appeared on the proxy with twin running on relay.bknd1.ninja.tf can't reach nodes running on relay.grid.tf. more details

muhamadazmy commented 3 months ago

Relay need to verify the twin data so that:

If destination twin has empty relays list, it need to return an immediate error to sender
If relay is an ip (not a dns name) this means twin has out-dated data and need to be treated as if it has no relays

Omarabdul3ziz commented 3 months ago

Versions

relay1 >> relay.grid.tf deployed with version 1.0.5 relay2 >> relay.02.grid.tf deployed with version 1.2.1 ninja relay >> relay.bknd1.ninja.tf deployed with version 1.2.1

Issue

federation doesn't work properly between different relays if one of them was relay1:

ninja relay to relay1 fails
relay2 to relay1 fails

knowing that it works fine on other stacks (tested between different relays on test net)

Reproduce

using the examples from the rmb-sdk

for server router
for client

sameh-farouk commented 3 months ago

Versions relay1 >> relay.grid.tf deployed with version 1.0.5 relay2 >> relay.02.grid.tf deployed with version 1.2.1 ninja relay >> relay.bknd1.ninja.tf deployed with version 1.2.1

Issue federation doesn't work properly between different relays if one of them was relay1:

ninja relay to relay1 fails relay2 to relay1 fails

Starting from Relay version 1.1.0, there were changes to the federation logic, and it transitioned from RMB to the relay. Federation between versions prior to and after this specific version is not supported. In general, it is expected for relays within the same network to run the same version.

Omarabdul3ziz commented 3 months ago

federation works fine now after upgrading relay.grid.tf to 1.2.1