threefoldtech / rmb-rs

RMB implementation in rust
Apache License 2.0
3 stars 1 forks source link

the error happens when twin can't be resolved (not found) need to be handled properly #36

Closed sameh-farouk closed 2 years ago

sameh-farouk commented 2 years ago

I was testing the new implementation and I expect a message to be pushed to the return queue with the err field filled with a proper error in cases like:

The second and third cases can be verified, but for the first case, it seems the error is not handled properly, it just shows in the debug log but no message would be returned to the client. so the client would wait unnecessarily till it timed out and won't have proper feedback about what goes wrong.

2022-05-31T21:19:12.548Z DEBUG [rmb_rs::http_workers::work_runner] can not retrieve twin from substrate for this id '90090' because of twin id is not found
muhamadazmy commented 2 years ago

Fixed