threefoldtech / rmb-rs

RMB implementation in rust
Apache License 2.0
3 stars 1 forks source link

HTTP workers should retry on 5xx HTTP errors too #60

Closed sameh-farouk closed 1 year ago

sameh-farouk commented 2 years ago

are there any reasons for not retrying a 5xx error? 5xx error codes should be retried as those are server errors. They could be short-term (busy server, etc) except for maybe 501 and 505.

muhamadazmy commented 2 years ago

Actually I am not sure about this one. retrying on an 5xx is not likely to be fix the issue. I would rather have a consistent behavior than special edge cases.