search

threefoldtech / rmb-rs

RMB implementation in rust
Apache License 2.0
3 stars 1 forks source link

document file uploads and add integration tests #80

Closed abom closed 1 year ago

abom commented 1 year ago

Related issues

abom commented 1 year ago

I added some tests, at first, it mostly failed because of the following error

failed to deliver message to remote rmb: error writing a body to connection: Broken pipe (os error 32): Broken pipe (os error 32)

I thought it's the timing and we should wait for rmb instance (other end), but found out we retry if we got 405 Method Not Allowed, so I just returned a Terminal error to stop retrying, it's now better and the test passes most of the times, but still getting this broken pipe randomly.

Another concern is the number if redis container we start for tests, while IMO, we can leverage the storage prefixes to use the same redis instance.

mohamedamer453 commented 1 year ago

Docs for the File Uploads were added and integration tests were also added in #81 . but there are no docs on how to run these tests so i was not able to verify if these tests are working or not.

mohamedamer453 commented 1 year ago

Verified.

I was able to run the tests using cargo test and all the added tests ran without any issues.

image

and the docs on how to run the tests will be followed in #86