threefoldtech / tf-kyc-verifier

The TFGrid KYC Verifier is a robust identity verification service integrated with iDenfy to ensue secure and compliant user deployments on TFGrid cloud
Apache License 2.0
0 stars 0 forks source link

Switch to default HTTP client instead of fasthttp #8

Open xmonader opened 1 week ago

xmonader commented 1 week ago

Why? https://github.com/valyala/fasthttp#faq

Are there known net/http advantages comparing to fasthttp?

Yes:

net/http supports HTTP/2.0 starting from go1.6.
net/http API is stable, while fasthttp API constantly evolves.
net/http handles more HTTP corner cases.
net/http can stream both request and response bodies
net/http can handle bigger bodies as it doesn't read the whole body into memory
net/http should contain less bugs, since it is used and tested by much wider audience.

_Originally posted by @xmonader in https://github.com/threefoldtech/tf-kyc-verifier/pull/4#discussion_r1830019091_

sameh-farouk commented 4 days ago

Update: PR ready for review