threefoldtech / tfchain

Threefold Chain.
Apache License 2.0
15 stars 11 forks source link

Fix inconsistencies in node contracts states #1010

Closed sameh-farouk closed 10 hours ago

sameh-farouk commented 1 week ago

Description

Related Issues:

https://github.com/threefoldtech/tfchain/issues/1002

Checklist:

Please delete options that are not relevant.

sameh-farouk commented 1 day ago

@renauter Thank you for your thoughtful review. I’ve addressed most of your comments.

I also appreciate the suggestion to add more assertions, but I believe these extra checks go beyond the scope of these test cases. The existing assertions already verify the core functionality being fixed, and adding more may detract from the specific focus of the test.