search

threefoldtech / tfchain_graphql

Graphql for TFchain
Apache License 2.0
2 stars 3 forks source link

Graphql do not list the farm public ips #194

Closed 0oM4R closed 6 days ago

0oM4R commented 2 weeks ago

image image

sameh-farouk commented 1 week ago

This behavior was explained earlier. The IP address 1.1.1.1 is associated with multiple farms, which is unreasonable. More context can be found here: GitHub Issue #157.

There was also a fix/workaround implemented in the dashboard to prevent adding an already used IP, but it seems you added this IP before the fix was applied, correct?

0oM4R commented 1 week ago

yes this added while ago, but what if i have the address now and the first user added it by mistake or no longer have it, so I will never be able to add it ?

sameh-farouk commented 6 days ago

Not ideal but yes, as allowing both of you to register same IP would introduce more issues. This was intended as a temporary solution until we can establish a better process and add some verification to the flow. See https://github.com/threefoldtech/tfchain_graphql/issues/157#issuecomment-2108192005 and https://github.com/threefoldtech/tfchain_graphql/issues/157#issuecomment-2120902303

I think it is reasonable to close this issue here as GraphQL is not to blame. In fact, Validating to prevent the IP from being registered on multiple farms is a workaround for a higher-level flow issue, which originally allowed this without ensuring the system remains consistent. However, we can revisit to modify or eliminate this validation here after considering the full image and the implications for other tools to ensure nothing else is adversely affected.