threefoldtech / tfgrid-sdk-go

Apache License 2.0
2 stars 4 forks source link

🐞 [Bug]: ZDB metadata is wrong #1128

Open A-Harby opened 3 months ago

A-Harby commented 3 months ago

What happened?

The ZDB is classified as VM not ZDB image

which network/s did you face the problem on?

Dev

Twin ID/s

No response

Version

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant log output

"workloads": [
    {
      "version": 0,
      "name": "node14meta0",
      "type": "zdb",
      "data": {
        "size": 1073741824,
        "mode": "user",
        "password": "password",
        "public": false
      },
Eslam-Nawara commented 3 months ago

zdbs types are set to default as we can mix workloads

A-Harby commented 3 months ago

zdbs types are set to default as we can mix workloads

On all of the other clients, it mentioned as ZDB and should be consistent with that.

Eslam-Nawara commented 3 months ago

zdbs types are set to default as we can mix workloads

On all of the other clients, it mentioned as ZDB and should be consistent with that.

I discussed it with @AbdelrahmanElawady and he mentioned that he agreed with @AhmedHanafy725 to leave it as default, since all deployments except networks and k8s are just deployments