threefoldtech / tfgrid-sdk-go

Apache License 2.0
2 stars 4 forks source link

The function of the `certification_type` parameter in the `/farms` endpoint is not clear. #62

Closed mohamedamer453 closed 1 year ago

mohamedamer453 commented 2 years ago

Description

The function of the certification_type parameter in the farms endpoint is not clear.

image

in the documentation the type can either be DIY or Certified but by checking the values returned from the farms endpoint, all of the farms have NotCertified in the certification type. even though NotCertified is not one of the values of this parameter according to the swagger docs.

image

and when the mentioned values DIY & Certified were added to the parameter it returned an empty list.

image

image

mohamedamer453 commented 1 year ago

After checking again on mainnet explorer i found that there are 2 certification types mentioned there NotCertified & Gold

image

https://gridproxy.grid.tf/farms?certification_type=Gold

image

https://gridproxy.grid.tf/farms?certification_type=NotCertified

image

so if these are the only certification types available then the swagger docs should be updated. and also another concern is that both options are case sensitive.

image

image

xmonader commented 1 year ago

Please check the FAQ https://manual.grid.tf/faq/faq.html?highlight=certific#what-are-the-different-certifications-available-for-3node-servers-and-farms-what-are-the-gold-and-silver-certifications and update the swagger with relevant info

A-Harby commented 1 year ago

Issue is fixed but its merged into development_1.0.0 branch and so its not deployed and can't be verified.

it need to be merged into development branch and released so we can verify.

mohamedamer453 commented 1 year ago

Verified on devnet.

The values of the certification_type parameter were added to the swagger docs.

image

However it was also changed for the /nodes endpoint and for nodes it should either be DIY or Certified not silver, gold, notCerified. https://github.com/threefoldtech/tfgrid-sdk-go/issues/335