search

threefoldtech / tfgrid-sdk-ts

Apache License 2.0
4 stars 8 forks source link

No error on network failure with node finder and no option to retry #2790

Closed scottyeager closed 2 months ago

scottyeager commented 4 months ago

I noticed the following behavior on the node finder:

  1. While my network connection was not super reliable, I tried filtering on a node id that I know is valid
  2. The result is just "no data available"
  3. The Apply button becomes greyed out, so I can't try again

There's two things I think can be improved about this:

  1. Present an error that network communication failed when that's the reason for no data (versus no data returned on a successful backend query)
  2. Allow the user to retry somehow when network comms is the cause of failure
maayarosama commented 4 months ago

Work completed:

Added an error variable which in case of error will display an error alert and a retry button

A-Harby commented 2 months ago

Verified, Devnet 0d964e5.

An alert with an error message and a retry button have been added. image

TC2735 - Retry on failed filter

scottyeager commented 2 months ago

Looks good, thanks!