search

threefoldtech / tfgrid-sdk-ts

Apache License 2.0
4 stars 8 forks source link

Update the `Delete IPs`, `Manage Ssh Keys` dialogs with `Chip-Group` component #2939

Open Mahmoud-Emad opened 1 month ago

Mahmoud-Emad commented 1 month ago

Which package/s are you suggesting this feature for?

Dashboard

Is your feature request related to a problem? Please describe

Vuetify offers a component called "chip-group," which is useful for including multiple chips in the same card and managing padding/margin. Please refer to the screenshot below.

image

Describe the solution you'd like

https://vuetifyjs.com/en/components/chip-groups/#usage

Also, we can remove the logic of selecting keys and use the vuetify one

Screencast from 06-10-2024 09:20:25 AM.webm

zaelgohary commented 1 month ago

Work completed:

Use chip group in delete public IP. Not usable in SSH page as multiple SSH keys feature is not active as of now.

Note: chip group doesn't pick up the chip color and this seems to be a problem from Vuetify which has been reported https://github.com/vuetifyjs/vuetify/issues/19678

zaelgohary commented 4 weeks ago

Used chip group in Manage SSH key section in solutions. I also used a margin for the chips in the delete dialogue.