🐞 [Bug]: Show/Hide icon in password field shouldn't be selectable

MohamedElmdary commented 5 days ago

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

Click tab while focusing on any password input will select the hide/show icon which badly impact UX because as a user I would expect to focus next input to continue entering data

Solution: We need to remove icon from tab index by setting tabindex="-1"

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

latest

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Relevant log output

None

samaradel commented 3 days ago

Work in progress:

investigating..

samaradel commented 2 days ago

Work Completed:

Remove password input wrapper
Create a prepend inner icon for inputs with type password
Fix show/hide icon selection when pressing tab
Fix the order of dialog actions tabindex

samaradel commented 1 day ago

Work in Progress (WIP):

trying another solution without deleting password-wrapper component

threefoldtech / tfgrid-sdk-ts