threefoldtech / tfgrid-sdk-ts

Apache License 2.0
4 stars 8 forks source link

Fix inputs with show/hide password icon #3045

Open samaradel opened 2 days ago

samaradel commented 2 days ago

Description

Changes

Screencast from 26-06-24 17:10:30.webm

Related Issues

Checklist

MohamedElmdary commented 2 days ago

@samaradel

PasswordInputWrapper component was created to avoid multiple define of showX variables. however this is not only the case but also to avoid defined v-slot:append-inner over and over. Also it's not only used in profile manager but also in multiple solution/apps for example k8s and it's currently broken. image

I would suggest extend usePasswordInput hook to get a ref from password input itself then use that ref in onMounted to append tabindex="-1" attribute in icon which should fix the issue in the entire app without any breaks.

Also Currently if we click on input then tab it will popup to the manual > Login > input again > the manual > So on... won't focus any button which definitely not fixing this issue at all

MohamedElmdary commented 2 days ago

image