threefoldtech / tfgrid-sdk-ts

Apache License 2.0
4 stars 8 forks source link

🐞 [Bug]: Review node pilot network options #3048

Closed 0oM4R closed 1 month ago

0oM4R commented 2 months ago

Is there an existing issue for this?

which package/s did you face the problem with?

Dashboard

What happened?

Node pilot has a newly added network component, but the filters are not updated with those changes. Currently, node pilot filters have ipv4 =true but the deployed instance doesn't have any this effects some features like custom domain name

https://github.com/threefoldtech/tfgrid-sdk-ts/blob/68fe8b88b99d4f01af705dfd805b97a34ea300ea/packages/playground/src/weblets/tf_node_pilot.vue#L54-L56

https://github.com/threefoldtech/tfgrid-sdk-ts/blob/68fe8b88b99d4f01af705dfd805b97a34ea300ea/packages/playground/src/weblets/tf_node_pilot.vue#L95

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

development_2.6

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Screenshot from 2024-06-27 13-59-17

Relevant log output

.
khaledyoussef24 commented 1 month ago

verified on devnet version : 0d964e5

deployed and worked fine

Image Image Image

should we add a column for public ipv4 and ipv6 in the deployment list or shall we open another issue for this

khaledyoussef24 commented 1 month ago

verified on devnet version : ac03039

Image

network columns for ipv4 and ipv6 are now added to deployment list