🐞 [Bug]: Discourse Mail Server is enabled despite the solution having no public IP

atefnazmy commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

While deploying Discourse application without a public IP, I observed that the Mail Server option is enabled and I could configure it and deploy the instance.

Steps To Reproduce

Navigate to the Dashboard
Navigate to Deploy from the sidebar then click on Applications.
Navigate to the Discourse deployment page by clicking on the Discourse card option
Expand the network option and turn off the public IPV4 toggle
Switch to the SMTP tab and add your smtp configuration and click the Deploy button

which network/s did you face the problem on?

Dev

version

cd929e2

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

https://github.com/threefoldtech/tfgrid-sdk-ts/assets/32517137/9e500630-6077-4684-81d9-b9b8aab41fce

Related Issue:

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2522

Relevant log output

n/a

samaradel commented 1 month ago

Work in Progress (WIP):

found an issue coming from zos working on it

samaradel commented 1 month ago

Work in Progress (WIP): The value of the switch is transformed somehow, debugging..

samaradel commented 1 month ago

Work Completed:

Fix discourse TLS switch on transform data

atefnazmy commented 1 month ago

The Issue is still producible as the SMTP option isn't disabled despite the solution having no public IP.

https://github.com/user-attachments/assets/d6deeca3-0da9-46a0-b22e-17be7663164f

khaledyoussef24 commented 1 month ago

the issue is still producable

khaledyoussef24 commented 2 weeks ago

verified now public ip and mail server are related version : 184fa12 in Discourse ipv4 is enabled and can not be disables so no problem with mail server

testcase

threefoldtech / tfgrid-sdk-ts