🐞 [Bug]: Connect your wallet is removed!

[A-Harby]

Is there an existing issue for this?

• [X] I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

Login as a new user (from incognito or new browser), can you can't see Connect your page anymore.

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

28e17de

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Relevant log output

.

[Mahmoud-Emad]

That happened because we normally save your hashed password into the local storage, since you opened a new browser you don't have rather wallet nor saved passwords, connected (saved passwords) you'll see the tab of connecting your wallet instead of login your wallet

This is an example from an incognito browser

another browser

[0oM4R]

I will give it about 1hour for investigation

[0oM4R]

Issue update : the cause is we are checking the active tab index 0,1 but actually we are in case of no credential stored we are passing array of one elment as tab, which is the connce wallet so the body of login appears. will work on the solution tmw

[0oM4R]

https://github.com/threefoldtech/tfgrid-sdk-ts/commit/28e17def150db77b2afd6f0faad40f41d28b1e2f just figured out that is this pr broke the logic, idk why yet but it is working fine on the commit before it. will give it more 2 hours of investigation to avoid changing the current profile manger logic

[0oM4R]

the issue is we are using async component to avoid load clients before set the stack url, but this lead tof unexpected behavior in the profile manager url. will investigate how should we resolve this issue, will update the estimated time to 8 hours

https://github.com/threefoldtech/tfgrid-sdk-ts/commit/28e17def150db77b2afd6f0faad40f41d28b1e2f#diff-39ab5393f74aa973412e9e454bf2f8d5725c108b2b42d6f7d62e30d04acf72a1R26-R28

[0oM4R]

Issue update : work completed; The issue was that we were importing the d-tabs component using defineAsyncComponent to avoid initializing clients before setting its urls by ServiceURLManager, This made the ProfileManager mount before the inner component Dtabs got imported.

[0oM4R]

will add 24h as estimated time for review

[A-Harby]

Verified, Dev a66e759.

Its back to normal.

TC2118 - Create a new twin

[A-Harby]

Devnet, a948bfa.

It got back to the same error again!

[0oM4R]

this issue returned on https://github.com/threefoldtech/tfgrid-sdk-ts/pull/3347, Rabie will investigate on this with the lazy load issue.

[khaledyoussef24]

while using private browsing in chrome and using also safari and firefox can not find the Create Account tab while opening the dashboard.

[ramezsaeed]

Also cannot find it on firefox

[0oM4R]

this issue returned on #3347, Rabie will investigate on this with the lazy load issue.

should be solved in https://github.com/threefoldtech/tfgrid-sdk-ts/pull/3475 @ramezsaeed @khaledyoussef24

[khaledyoussef24]

verified issue is no more longer reproducible tested in safari and private mode

version : 038404b

[ramezsaeed]

Verified:

• Devnet
• a516b1b
• chrome