threefoldtech / tfgrid-sdk-ts

Apache License 2.0
4 stars 8 forks source link

🐞 [Bug]: Gateway network contract not deleted after failing to deploy #3390

Open zaelgohary opened 1 week ago

zaelgohary commented 1 week ago

Is there an existing issue for this?

which package/s did you face the problem with?

Dashboard

What happened?

I tried to deploy a domain for my VM using a custom domain and it failed during deployment. However, I noticed that no rollback happened to the created network contract.

image

image

Now, when I try to deploy another domain, it shows this error:

image

Steps To Reproduce

which network/s did you face the problem on?

Dev

version

ea80744

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

attached above

Relevant log output

`Failed to deploy the deployment on node 11. Failed to send request to twinId 21 with command: zos.deployment.deploy, payload: {"version":0,"metadata":"{\"version\":3,\"type\":\"network\",\"name\":\"nws1rxs\",\"projectName\":\"vm/vmyq8e8\"}","description":"","twin_id":89,"expiration":0,"workloads":[{"version":0,"name":"nws1rxs","type":"network","data":{"subnet":"10.20.2.0/24","ip_range":"10.20.0.0/16","wireguard_private_key":"lBIlM8lP9I46ImN7f939X9lvpuma0wtBkSITA85UmMo=","wireguard_listen_port":20712,"node_id":11,"peers":[]},"metadata":"{\"version\":3,\"user_accesses\":[]}","description":""}],"signature_requirement":{"requests":[{"twin_id":89,"weight":1,"required":false}],"signatures":[{"twin_id":89,"signature":"02f7139c31f886e46d5e474d2c87397d268ed81e55efd90ce812fd5c8be7284b2161bed35ed8ee10dc42a60f79bf7f27f0895e6d2f98f89a96d921f348f9aa81","signature_type":"sr25519"}],"weight_required":1},"contract_id":149941} RMBError: 0 global workload with the same name 'nws1rxs' exists: conflict`
zaelgohary commented 3 days ago

Needs to investigate why network type is inconsistent. Related to https://github.com/threefoldtech/tfgrid-sdk-ts/issues/3378.

zaelgohary commented 3 days ago

Investigate what happens while rolling back.