🐞 [Bug]: Domain in public config accepts wrong formats - Githubissues

threefoldtech / tfgrid-sdk-ts

Apache License 2.0

4 stars 8 forks source link

🐞 [Bug]: Domain in public config accepts wrong formats #3633

Open zaelgohary opened 2 weeks ago

zaelgohary commented 2 weeks ago

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

Domain field accepts wrong formats.

https://app.testlodge.com/a/26076/projects/40893/runs/757631/run?selected=33242682&user_id=170529

Steps To Reproduce

From the sidebar, click on Your Farms then Your Farms.
In the Your Nodes table Click on the Add Public Config Icon for any of the nodes.
Try entering the following formats in domain field:
- mydomain.unknown
- my@domain.com

which network/s did you face the problem on?

Dev

version

96e183a

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

-

Relevant log output

ramezsaeed commented 1 week ago

need to add the same domain validator used in caprover.