A lot of errors appears in console while the DAO page is loading

[A-Harby]

Description

A lot of errors appears in console while the DAO page is loading

Logs/Alerts

[0oM4R]

As I discussed with @AhmedHanafy725 this is related to tfchain, please transfer it there

[DylanVerstraete]

@AhmedHanafy725 can you share your thoughts here?

[xmonader]

@AhmedHanafy725 @DylanVerstraete I assigned you both on the issue so it won't be forgotten

[AhmedHanafy725]

when trying to get the proposals from the chain, it raises this error. not sure if it's related to the types or if the proposal itself has an issue on the chain

when tried to get them with Polkadot, some of them return objects and some are unknown

these are some of the worked ones:

• 0x947e4f16b5ebba864d67f0ff02cf3fd0707957ff9f817943df8d59f48fe0b103
• 0xdf81840bed93907ff29644452de3c376bf38358e4cd59e98bffebb155147f8f5

not worked ones:

• 0xdf81840bed93907ff29644452de3c376bf38358e4cd59e98bffebb155147f8f5
• 0x35ea8aa0991e493122c1365d26ef0d9e041f369202cddc1b528b13a27e6f6fc2
• 0x262389812016418e48f3e8ddf92f4d5184e24f40c58dc9d00625806f1b5639b8
• 0xdd4f32ae842e034626becade94de33c4afe0037b7b03b4d267b4dbfad4ba1b9f
• 0x5548c1690856e626bfdd861fec662c4e0fd8d76408256eda3e8738ba927a8c8e

[DylanVerstraete]

Probably these proposals contain types that aren't deserializable anymore with current runtime. I will close these proposals

[DylanVerstraete]

Seems these proposals that have <unknown> call cannot be closed with error: https://github.com/threefoldtech/tfchain/blob/0e20bc81b066c7c1a5915bee2441be081a1cbd3c/substrate-node/pallets/pallet-dao/src/dao.rs#L254

It seems that some of these proposals have votes and cannot be close because the call is not serializable. This should be addressed.

Also, it seems that proposals with an unmet threshold and expired end time can be closed and approved:

Example proposal:

When trying to close this proposal, the outcome is approved because of this check https://github.com/threefoldtech/tfchain/blob/0e20bc81b066c7c1a5915bee2441be081a1cbd3c/substrate-node/pallets/pallet-dao/src/dao.rs#L207-L211

The end date is met but the threshold not, still it passes the above check.

[DylanVerstraete]

Will create seperate issues for the 2 above described cases

[DylanVerstraete]

@A-Harby since this issue actually belongs in the Tfgrid-TS-sdk repo I will move it there. https://github.com/threefoldtech/tfchain/issues/803 and https://github.com/threefoldtech/tfchain/issues/804 were created on this repo to track the needed runtime upgrades to clean up the remaining proposals

[DylanVerstraete]

Proposed solution: handle errors decoding proposals in the client