Stellar Wallet Secret works correctly despite the addition of extra Character

atefnazmy commented 4 weeks ago

Description:

The secret input field for adding a Stellar wallet allows entry of the secret key plus one additional character and it works correctly after clicking on save.

Steps to Reproduce:

1.Open the TF-Connect App . 2.Click on "Wallet" in menu items. 3.Write your PIN code. 4.Click on "+" Symbol on the top right of the page. 5.Write Wallet name in "Wallet Name" and Stellar address in "Secret" 6.Add one more Character (57 Character instead of 56) 6.Click on "Save" button.

Expected Behavior:

The Secret input should not accept wrong length for the Stellar secret key

Screenshot Of the Issue:

https://github.com/user-attachments/assets/c6adb163-b705-4d02-8388-60c441d4fb1b

Environment:

• OS Version: Android 14 • App Version: 3.9.1

zaelgohary commented 3 weeks ago

Work completed:

The issue happened because the generateHexSeed returned the same value for both secret & secret + a. The issue is from stellar_flutter_sdk package. Fixed by checking the seed length before generating hex.

khaledyoussef24 commented 2 weeks ago

verified IOS 18 Version 4.0.0 Issue is no longer reproducible

testcase

threefoldtech / threefold_connect