Eth: example eth to tft to deploy vm

threefoldtech / web3gw

Proxy for the web3 world

Apache License 2.0

1 stars 1 forks source link

Eth: example eth to tft to deploy vm #117

Closed brandonpille closed 1 year ago

brandonpille commented 1 year ago

Completes #63:

Added example
Added documentation

DylanVerstraete commented 1 year ago

While the code looks great, I think the example should not ask for a Stellar and Tfchain key.

The main reason we want to have this example is to have a seamless experience for an ethereum user having only an ethereum key. All the other keys should be generated on the fly as they are not provided by the user.

robvanmieghem commented 1 year ago

While the code looks great, I think the example should not ask for a Stellar and Tfchain key.

The main reason we want to have this example is to have a seamless experience for an ethereum user having only an ethereum key. All the other keys should be generated on the fly as they are not provided by the user.

Agree but this PR has some necessary changes and value without that functionality too. I would merge this PR and leave that functionality as a TODO in the github issue.

robvanmieghem commented 1 year ago

Since the main purpose of this example are demo's, I would default all networks to production.

The Ethereum Goerli network is marked as deprecated, it requires special knowledge how to configure your Ethereum client and getting Goerli Eth.
Stellar testnet is reset regularly
Testnet bridges are not guaranteed to be up
devnet tfchain and grid are subject to frequent changes which might cause downtime and incompatibilities and we don't want to make devnet a 'production' version which it will become if it is used for demo's.

In other words, testnets and devnets are for developers

This will also make the manual simpler