threefoldtech / web3gw

Proxy for the web3 world
Apache License 2.0
1 stars 1 forks source link

146 openrpc document is not correct #156

Closed timurgordon closed 1 year ago

timurgordon commented 1 year ago

Fixes #146 One of the problems that caused the issue was: "Metrics client library RPC call is not declared in the standard other clients follow, where the client is the receiver of the function. This is presumably because methods can't be declared outside modules."

As part of the solution commit 165f6c8 ignores the metrics module in OpenRPC Document generation. @ashraffouda is that acceptable, or is the metrics method required to be included in the document. If so can we consider merging it into the explorer module to have the client passed to the function as a receiver and not as a parameter.